fix(remote-config, web): getAll() API throwing runtime exception wi…

…th incorrect cast to `List<String>` (#12602)
firebase · Apr 9, 2024 · 70e257e · 70e257e
1 parent 2cc1618
commit 70e257e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/...base_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart b/...base_remote_config/firebase_remote_config_web/lib/src/interop/firebase_remote_config.dart
@@ -106,9 +106,12 @@ class RemoteConfig
 
   /// Returns all config values.
   Map<String, RemoteConfigValue> getAll() {
-    final keys =
-        remote_config_interop.getAll(jsObject).dartify()! as List<String>;
-    final entries = keys.map<MapEntry<String, RemoteConfigValue>>(
+    // Return type is Map<Object?, Object?>
+    final map = remote_config_interop.getAll(jsObject).dartify()!
+        as Map<Object?, Object?>;
+    // Cast the map to <String, Object?> to mirror expected return type: Record<string, Value>;
+    final castMap = map.cast<String, Object?>();
+    final entries = castMap.keys.map<MapEntry<String, RemoteConfigValue>>(
       (dynamic k) => MapEntry<String, RemoteConfigValue>(k, getValue(k)),
     );
     return Map<String, RemoteConfigValue>.fromEntries(entries);

diff --git a/tests/integration_test/firebase_remote_config/firebase_remote_config_e2e_test.dart b/tests/integration_test/firebase_remote_config/firebase_remote_config_e2e_test.dart
@@ -77,6 +77,11 @@ void main() {
             FirebaseRemoteConfig.instance.getValue('nonexisting').source,
             ValueSource.valueStatic,
           );
+
+          expect(
+            FirebaseRemoteConfig.instance.getAll(),
+            isA<Map<String, RemoteConfigValue>>(),
+          );
         },
         // iOS v9.2.0 hangs on ci if `fetchAndActivate()` is used, but works locally.
         // macOS skipped because it needs keychain sharing entitlement. See: https://github.com/firebase/flutterfire/issues/9538