fix(auth): fix MFA issue where the error wouldn't be properly catched (…

…#11370)
firebase · Jul 26, 2023 · 72fef03 · 72fef03
1 parent e925b4c
commit 72fef03
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m b/packages/firebase_auth/firebase_auth/ios/Classes/FLTFirebaseAuthPlugin.m
@@ -466,7 +466,7 @@ - (void)handleMultiFactorError:(PigeonFirebaseApp *)app
                                                  FlutterError *_Nullable))completion
                      withError:(NSError *_Nullable)error {
 #if TARGET_OS_OSX
-  completion(nil, [FlutterError errorWithCode:@"multi-factor-auth-required"
+  completion(nil, [FlutterError errorWithCode:@"second-factor-required"
                                       message:error.description
                                       details:nil]);
 #else
@@ -508,7 +508,7 @@ - (void)handleMultiFactorError:(PigeonFirebaseApp *)app
     kArgumentMultiFactorSessionId : sessionId,
     kArgumentMultiFactorResolverId : resolverId,
   };
-  completion(nil, [FlutterError errorWithCode:@"multi-factor-auth-required"
+  completion(nil, [FlutterError errorWithCode:@"second-factor-required"
                                       message:error.description
                                       details:output]);
 #endif

diff --git a/...irebase_auth/firebase_auth_platform_interface/lib/src/method_channel/utils/exception.dart b/...irebase_auth/firebase_auth_platform_interface/lib/src/method_channel/utils/exception.dart
@@ -77,7 +77,7 @@ FirebaseException platformExceptionToFirebaseAuthException(
 
   if (details != null) {
     code = details['code'] ?? code;
-    if (code == 'second-factor-required') {
+    if (code == kMultiFactorError) {
       return parseMultiFactorError(platformException);
     }