fix(ml_downloader): fixed an issue where macOS builds failed due to b…

…ug with missing pod subspec in Firebase SDK (added a workaround until issue fixed upstream).
firebase · Jan 10, 2022 · acc6afa · acc6afa
1 parent 7bd14e0
commit acc6afa
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...l_downloader/firebase_ml_model_downloader/ios/Classes/FirebaseModelDownloaderPlugin.swift b/...l_downloader/firebase_ml_model_downloader/ios/Classes/FirebaseModelDownloaderPlugin.swift
@@ -10,7 +10,6 @@
 
 import FirebaseCore
 import FirebaseMLModelDownloader
-import UIKit
 
 import firebase_core
 
@@ -78,7 +77,7 @@ public class FirebaseModelDownloaderPluginSwift: FLTFirebasePlugin, FlutterPlugi
                                                   andOptionalNSError: nil))
     }
 
-    var result = FLTFirebaseMethodCallResult.create(success: result, andErrorBlock: errorBlock)
+    let result = FLTFirebaseMethodCallResult.create(success: result, andErrorBlock: errorBlock)
     if call.method == "FirebaseModelDownloader#getModel" {
       getModel(arguments: call.arguments as! [String: Any], result: result)
     }

diff --git a/..._model_downloader/firebase_ml_model_downloader/macos/firebase_ml_model_downloader.podspec b/..._model_downloader/firebase_ml_model_downloader/macos/firebase_ml_model_downloader.podspec
@@ -52,7 +52,9 @@ Pod::Spec.new do |s|
 
   # Firebase dependencies
   s.dependency 'Firebase/CoreOnly', "~> #{firebase_sdk_version}"
-  s.dependency 'Firebase/MLModelDownloader', "~> #{firebase_sdk_version}"
+  # TODO(Salakar): Direct pod depency here instead of the Firebase subspec due to:
+  # https://github.com/firebase/firebase-ios-sdk/pull/9186 (pending acceptance / merge)
+  s.dependency 'FirebaseMLModelDownloader', '~> 8.10.0-beta'
   s.static_framework = true
   s.swift_version = '5.0'
   s.pod_target_xcconfig = {