Skip to content

Commit

Permalink
fix(messaging): revert change to getParcelableExtra() that may resu…
Browse files Browse the repository at this point in the history
…lt in crash (#11163)
  • Loading branch information
russellwheatley committed Jun 22, 2023
1 parent 3135815 commit b85e074
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -229,14 +229,11 @@ public void notImplemented() {

// Handle the message event in Dart.
RemoteMessage remoteMessage;

if (android.os.Build.VERSION.SDK_INT >= 33) {
remoteMessage =
intent.getParcelableExtra(
FlutterFirebaseMessagingUtils.EXTRA_REMOTE_MESSAGE, RemoteMessage.class);
} else {
remoteMessage = intent.getParcelableExtra(FlutterFirebaseMessagingUtils.EXTRA_REMOTE_MESSAGE);
}
// Using android >= 33 API causes sporadic crashes. See: https://github.com/firebase/flutterfire/issues/11142
// remoteMessage =
// intent.getParcelableExtra(
// FlutterFirebaseMessagingUtils.EXTRA_REMOTE_MESSAGE, RemoteMessage.class);
remoteMessage = intent.getParcelableExtra(FlutterFirebaseMessagingUtils.EXTRA_REMOTE_MESSAGE);

if (remoteMessage != null) {
Map<String, Object> remoteMessageMap =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
}

dependencies {
classpath 'com.android.tools.build:gradle:8.0.1'
classpath 'com.android.tools.build:gradle:7.4.1'
classpath 'com.google.gms:google-services:4.3.15'
}
}
Expand All @@ -25,6 +25,6 @@ subprojects {
project.evaluationDependsOn(':app')
}

task clean(type: Delete) {
tasks.register("clean", Delete) {
delete rootProject.buildDir
}

0 comments on commit b85e074

Please sign in to comment.