Skip to content

Commit

Permalink
fix(firestore, web): use enableMultiTabIndexedDbPersistence() API w…
Browse files Browse the repository at this point in the history
…hen the user inputs `synchronizeTabs` as `true` (#10024)
  • Loading branch information
russellwheatley committed Dec 8, 2022
1 parent be4b42b commit d75786f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,14 @@ class Firestore extends JsObjectWrapper<firestore_interop.FirestoreJsImpl> {
firestore_interop.doc(jsObject, documentPath));

Future<void> enablePersistence(
[firestore_interop.PersistenceSettings? settings]) =>
handleThenable(
firestore_interop.enableIndexedDbPersistence(jsObject, settings));
[firestore_interop.PersistenceSettings? settings]) {
if (settings != null && settings.synchronizeTabs == true) {
return handleThenable(
firestore_interop.enableMultiTabIndexedDbPersistence(jsObject));
}
return handleThenable(
firestore_interop.enableIndexedDbPersistence(jsObject));
}

Stream<void> snapshotsInSync() {
late StreamController<void> controller;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,8 @@ external PromiseJsImpl<void> enableIndexedDbPersistence(

@JS()
external PromiseJsImpl<void> enableMultiTabIndexedDbPersistence(
FirestoreJsImpl firestore);
FirestoreJsImpl firestore,
);

@JS()
external PromiseJsImpl<void> enableNetwork(FirestoreJsImpl firestore);
Expand Down

0 comments on commit d75786f

Please sign in to comment.