fix(firestore, web): fix interop on TransactionOptions (#9188)

firebase · Jul 22, 2022 · f020167 · f020167
1 parent bf1d9be
commit f020167
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore.dart b/packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore.dart
@@ -104,7 +104,8 @@ class Firestore extends JsObjectWrapper<firestore_interop.FirestoreJsImpl> {
     return handleThenable(firestore_interop.runTransaction(
             jsObject,
             updateFunctionWrap,
-            firestore_interop.TransactionOptionsJsImpl(maxAttempts)))
+            firestore_interop.TransactionOptionsJsImpl(
+                maxAttempts: maxAttempts)))
         .then((value) => dartify(null));
   }
 

diff --git a/packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore_interop.dart b/packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore_interop.dart
@@ -193,11 +193,12 @@ external PromiseJsImpl<void> runTransaction(
 ]);
 
 @JS('TransactionOptions')
-class TransactionOptionsJsImpl {
-  external factory TransactionOptionsJsImpl(num maxAttempts);
+@anonymous
+abstract class TransactionOptionsJsImpl {
+  external factory TransactionOptionsJsImpl({num maxAttempts});
 
   /// Maximum number of attempts to commit, after which transaction fails. Default is 5.
-  external num get maxAttempts;
+  external static num get maxAttempts;
 }
 
 @JS()