fix(auth, web): lower SDK minimum version constraint to "3.2.0" (#12369)

firebase · Feb 23, 2024 · fa412b4 · fa412b4
1 parent 2bbe0b0
commit fa412b4
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 9 deletions.
diff --git a/packages/firebase_auth/firebase_auth_web/lib/src/interop/auth.dart b/packages/firebase_auth/firebase_auth_web/lib/src/interop/auth.dart
@@ -33,7 +33,7 @@ Auth getAuthInstance(App app) {
       app.jsObject,
       auth_interop.AuthOptions(
         errorMap: auth_interop.debugErrorMap,
-        persistence: persistences.toJS,
+        persistence: customJSList(persistences),
         popupRedirectResolver: auth_interop.browserPopupRedirectResolver,
       ),
     ),

diff --git a/packages/firebase_auth/firebase_auth_web/lib/src/interop/auth_interop.dart b/packages/firebase_auth/firebase_auth_web/lib/src/interop/auth_interop.dart
@@ -20,15 +20,15 @@ external AuthJsImpl getAuth([AppJsImpl? app]);
 @JS()
 external AuthJsImpl initializeAuth(AppJsImpl app, AuthOptions authOptions);
 
-extension type AuthOptions._(JSObject o) implements JSObject {
-  external AuthOptions({
-    JSObject errorMap,
+@anonymous
+@JS()
+@staticInterop
+abstract class AuthOptions {
+  external factory AuthOptions({
+    JSObject? errorMap,
     JSArray? persistence,
     JSObject? popupRedirectResolver,
   });
-  external JSObject? get errorMap;
-  external JSArray? get persistence;
-  external JSObject? get popupRedirectResolver;
 }
 
 @JS('debugErrorMap')
@@ -359,7 +359,10 @@ extension UserJsImplExtension on UserJsImpl {
 ///
 /// See: <https://firebase.google.com/docs/reference/js/firebase.auth.Auth#.Persistence>
 @JS('Persistence')
-extension type Persistence._(JSObject _) implements JSObject {
+@staticInterop
+class Persistence {}
+
+extension PersistenceExtension on Persistence {
   external JSString get type;
 }
 

diff --git a/packages/firebase_auth/firebase_auth_web/pubspec.yaml b/packages/firebase_auth/firebase_auth_web/pubspec.yaml
@@ -5,7 +5,7 @@ repository: https://github.com/firebase/flutterfire/tree/master/packages/firebas
 version: 5.9.5
 
 environment:
-  sdk: '>=3.3.0 <4.0.0'
+  sdk: '>=3.2.0 <4.0.0'
   flutter: '>=3.3.0'
 
 dependencies:

diff --git a/packages/firebase_core/firebase_core_web/lib/src/interop/utils/utils.dart b/packages/firebase_core/firebase_core_web/lib/src/interop/utils/utils.dart
@@ -62,6 +62,11 @@ dynamic jsifyList(
   return js.toJSArray(list.map((item) => jsify(item, customJsify)).toList());
 }
 
+/// Converts a List into a JS Array without converting the items.
+dynamic customJSList(List list) {
+  return js.toJSArray(list.toList());
+}
+
 /// Returns the JS implementation from Dart Object.
 ///
 /// The optional [customJsify] function may return `null` to indicate,