Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_remote_config): add documentation what is returned when the key does not exist for getBool, getInt, getDouble and getString #10573

Merged
merged 1 commit into from Apr 25, 2023

Conversation

nilsreichardt
Copy link
Contributor

Description

You might expect that the methods are returning null or throwing an exception. But Firebase returns default values. Therefore, I added the values which are returned when the key for the methods does not exist.

Got the values from here:https://firebase.google.com/docs/reference/android/com/google/firebase/remoteconfig/FirebaseRemoteConfig

Zapp Online Demo for default values: https://zapp.run/edit/firebaseremoteconfig-3014-zd6206xrd630?entry=lib/main.dart&file=lib/main.dart

Related Issues

...

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

… the key does not exist for `getBool`, `getInt`, `getDouble` and `getString`
@russellwheatley
Copy link
Member

I wonder if we could add e2e tests to show this is cross platform 🤔

@nilsreichardt
Copy link
Contributor Author

I wonder if we could add e2e tests to show this is cross platform 🤔

@russellwheatley #10723 adds tests for this :)

@russellwheatley russellwheatley merged commit 37c5f27 into firebase:master Apr 25, 2023
13 checks passed
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants