Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_auth): export AuthProvider from firebase_auth_interface #11470

Merged

Conversation

nilsreichardt
Copy link
Contributor

@nilsreichardt nilsreichardt commented Aug 15, 2023

Description

In SharezoneApp/sharezone-app#445 we needed to import AuthProvider to mock a User from the firebase_auth package. However, because AuthProvider is not exported by firebase_auth, we were forced to add firebase_auth_interface as a dependency, what feels a bit weird. See https://github.com/SharezoneApp/sharezone-app/pull/445/files#diff-eb39b18ab1eafcf41f3b8e2bdab898fb3a97b376ea849067d640fd1eabf12ac8R70.

Therefore, I added the AuthProvider as export in the firebase_auth package.

Related Issues

No issue.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley
Copy link
Member

@nilsreichardt - do you mind merging with master, please?

@nilsreichardt
Copy link
Contributor Author

@nilsreichardt - do you mind merging with master, please?

@Lyokone Lyokone merged commit 39881e7 into firebase:master Nov 7, 2023
20 of 22 checks passed
@firebase firebase locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants