fix(auth): ensure PigeonAuthCredential
is passed back to Dart side within try/catch
#11683
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Whilst testing this code, I observed a few issues:
AuthCredential
when present on the exception which was an issue for both andriod and iOS. Fixed here.AuthCredential
on iOS side, we needed to pass back thePigeonAuthCredential
. Fixed here.signInWithCredential
afterlinkWithProvider
failed with this exception codecredential-already-in-use
, we were receiving an exception code forsignInWithCredential
that was network error code (i.e. the number "400"), I have updated to check if the error code is a number and responded with the underlying error code. Fixed here.Related Issues
fixes #11164
fixes #11686
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?