Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): setCurrentScreen() was deprecated, using logScreenView() instead #12085

Merged
merged 2 commits into from Jan 5, 2024

Conversation

kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Dec 28, 2023

Description

Fix #11035

Related Issues

#9397
#11035

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@kzrnm kzrnm changed the title setCurrentScreen is deprecated fix(analytics): setCurrentScreen() was deprecated, using logScreenView() instead Dec 28, 2023
@kzrnm kzrnm changed the title fix(analytics): setCurrentScreen() was deprecated, using logScreenView() instead fix(analytics, web): setCurrentScreen() was deprecated, using logScreenView() instead Dec 28, 2023
@kzrnm kzrnm changed the title fix(analytics, web): setCurrentScreen() was deprecated, using logScreenView() instead fix(analytics): setCurrentScreen() was deprecated, using logScreenView() instead Dec 28, 2023
@russellwheatley
Copy link
Member

@kzrnm kzrnm force-pushed the setCurrentScreen branch 2 times, most recently from 68b1f61 to 9f2bf77 Compare January 2, 2024 11:18
@kzrnm
Copy link
Contributor Author

kzrnm commented Jan 2, 2024

@russellwheatley I fixed conflicts, and add logScreenView().

@Lyokone Lyokone merged commit c6341b9 into firebase:master Jan 5, 2024
18 checks passed
@kzrnm kzrnm deleted the setCurrentScreen branch January 5, 2024 16:59
@firebase firebase locked and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[📚] setCurrentScreen method should be annotated as Deprecated
4 participants