Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics, web): setCurrentScreen() API is now obsolete, using logEvent() instead #9397

Merged
merged 1 commit into from Aug 24, 2022

Conversation

russellwheatley
Copy link
Member

Description

setCurrentScreen() is now obsolete. Using logEvent() as documentation recommends.

Using firebase_screen parameter as mentioned in docs.

Related Issues

fixes #8403

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley added type: bug Something isn't working plugin: analytics platform: web Issues / PRs which are specifically for web. labels Aug 24, 2022
@russellwheatley russellwheatley merged commit 490ef20 into master Aug 24, 2022
@russellwheatley russellwheatley deleted the @russell/analytics-8403 branch August 24, 2022 10:33
@firebase firebase locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: web Issues / PRs which are specifically for web. plugin: analytics type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_analytics] page/screen views are not being sent for web
3 participants