Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(firebase_messaging): fix usage link to the documentation in the README.md #9027

Merged
merged 1 commit into from Jul 4, 2022

Conversation

adnanjpg
Copy link
Contributor

@adnanjpg adnanjpg commented Jul 2, 2022

Description

the Usage link in the README of firebase_messaging was pointing to the firestore documentation. this PR changes that link to point to the firebase_messaging documentation.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@nilsreichardt
Copy link
Contributor

nilsreichardt commented Jul 2, 2022

@adnanjpg Thanks for your PR! ❤️ Can you add the type of your PR to follow the conventional commits? Something like "docs(firebaes_messaging): fix usage link to the documentation in the README.md"

@adnanjpg adnanjpg changed the title update the Cloud Messaging Usage documentation url from firestore to … docs(cloud_firestore): fix usage link to the documentation in the README.md Jul 2, 2022
@adnanjpg adnanjpg changed the title docs(cloud_firestore): fix usage link to the documentation in the README.md docs(firebase_messaging): fix usage link to the documentation in the README.md Jul 2, 2022
@adnanjpg
Copy link
Contributor Author

adnanjpg commented Jul 2, 2022

@nilsreichardt Sure, I've updated the title and the comment accordingly!

@russellwheatley russellwheatley merged commit 037e3a5 into firebase:master Jul 4, 2022
@firebase firebase locked and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants