Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_auth): use correct UTC time from server for _webUser.metadata.creationTime & _webUser.metadata.lastSignInTime #9789

Merged
merged 1 commit into from Oct 31, 2022

Conversation

jorgeroncero
Copy link
Contributor

@jorgeroncero jorgeroncero commented Oct 25, 2022

Description

// On firebase-admin (server)
console.log(user.metadata.creationTime); // Mon, 25 Oct 2022 10:17:31 GMT
// As currently implemented
print('${DateFormat('EEE, d MMM yyyy HH:mm:ss', 'en_US').parse(_webUser.metadata.creationTime!)}'); // 2022-10-25 09:17:31.699

// Fix
print('${DateFormat('EEE, d MMM yyyy HH:mm:ss', 'en_US').parse(_webUser.metadata.creationTime!, true)}'); // 2022-10-25 10:17:31.699Z

Related Issues

WEB support to complement PR #9248
Fixes #9162 in WEB

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

…adata.creationTime & _webUser.metadata.lastSignInTime
@russellwheatley russellwheatley changed the title fix(firebase_auth): use correct UTC time from server for _webUser.metadata.creationTime & _webUser.metadata.lastSignInTime fix(firebase_auth): use correct UTC time from server for _webUser.metadata.creationTime & _webUser.metadata.lastSignInTime Oct 26, 2022
@Lyokone Lyokone merged commit 44ac2a3 into firebase:master Oct 31, 2022
@Lyokone
Copy link
Contributor

Lyokone commented Oct 31, 2022

Thanks for the PR :)

@firebase firebase locked and limited conversation to collaborators Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] user.metdata.creationTime wrong milliseconds
3 participants