Skip to content

fix(firebase_auth): use correct UTC time from server for currentUser?.metadata.creationTime & currentUser?.metadata.lastSignInTime #9248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

russellwheatley
Copy link
Member

Description

// On firebase-admin (server)
console.log(user.metadata.creationTime); // Mon, 18 Jul 2022 10:17:31 GMT
// As currently implemented
print('${DateTime.fromMillisecondsSinceEpoch(_creationTimestamp!)}'); // 2022-07-18 11:17:31.699

// Fix
print('${DateTime.fromMillisecondsSinceEpoch(_creationTimestamp!, isUtc: true)}'); // 2022-07-18 10:17:31.699Z

Related Issues

fixes #9162

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(firebase_auth): use correct UTC time from server fix(firebase_auth): use correct UTC time from server for currentUser?.metadata.creationTime Jul 28, 2022
@russellwheatley russellwheatley changed the title fix(firebase_auth): use correct UTC time from server for currentUser?.metadata.creationTime fix(firebase_auth): use correct UTC time from server for currentUser?.metadata.creationTime & 'currentUser?.metadata.lastSignInTime' Jul 28, 2022
@russellwheatley russellwheatley changed the title fix(firebase_auth): use correct UTC time from server for currentUser?.metadata.creationTime & 'currentUser?.metadata.lastSignInTime' fix(firebase_auth): use correct UTC time from server for currentUser?.metadata.creationTime & currentUser?.metadata.lastSignInTime Jul 28, 2022
@russellwheatley russellwheatley added type: bug Something isn't working plugin: auth labels Aug 1, 2022
@russellwheatley russellwheatley merged commit a620412 into master Aug 10, 2022
@russellwheatley russellwheatley deleted the @russell/auth-9162 branch August 10, 2022 12:20
@firebase firebase locked and limited conversation to collaborators Sep 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: auth type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_auth] user.metdata.creationTime wrong milliseconds
3 participants