Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(firestore, web): change interop type of updateDoc to force the JS interop to keep the value #10491

Merged
merged 1 commit into from
Feb 20, 2023
Merged

fix(firestore, web): change interop type of updateDoc to force the JS interop to keep the value #10491

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions packages/cloud_firestore/cloud_firestore_web/lib/src/interop/firestore_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,13 +213,9 @@ external bool snapshotEqual(
@JS()
external PromiseJsImpl<void> terminate(FirestoreJsImpl firestore);

// Object type is forced to prevent JS interop from ignoring the value
@JS()
external PromiseJsImpl<void> updateDoc(
DocumentReferenceJsImpl reference,
/*string | FieldPath*/ dynamic field,
dynamic value, [
dynamic moreFieldsAndValues,
]);
external Object get updateDoc;

@JS()
external PromiseJsImpl<void> waitForPendingWrites(FirestoreJsImpl firestore);
Expand Down