fix(crashlytics, ios): fix Crashlytics obfuscation for iOS on the Flutter side #10566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrober
approved these changes
Mar 6, 2023
themiswang
changed the title
themiswang
changed the title
mrober
reviewed
Mar 6, 2023
packages/firebase_crashlytics/firebase_crashlytics/lib/src/utils.dart
Outdated
Show resolved
Hide resolved
themiswang
force-pushed
the
obfuscatedFixing
branch
2 times, most recently
from
5ed9e75
to
9124a70
Compare
themiswang
force-pushed
the
obfuscatedFixing
branch
from
9124a70
to
ed44773
Compare
russellwheatley
approved these changes
Mar 7, 2023
packages/firebase_crashlytics/firebase_crashlytics/lib/src/utils.dart
Outdated
Show resolved
Hide resolved
russellwheatley
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make plugin to send abs address to Crashlytics to make deobfuscation works on iOS.
Crashlytics is smart enough to grouping same errors with different abs addresses in the same issue.
Related Issues
#8934
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?