New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(messaging): Throw exception if APNS token is not yet available #11400
Merged
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
57a40e6
fix(messaging): Throw exception if APNS token is not yet available
russellwheatley 087fa54
docs(messaging): inform users the APNS token is required on Apple pla…
russellwheatley 1041127
chore(messaging): return type for function
russellwheatley 04dc3cc
docs(messaging): ensure `getToken()` is called early
russellwheatley 907a14e
Merge branch 'master' into messaging-10625
russellwheatley 963a2a6
docs(messaging): remove section about getToken() API call requirement
russellwheatley 62516ce
Merge branch 'master' into messaging-10625
russellwheatley 6ce0ca7
Apply suggestions from code review
russellwheatley b875b24
Merge branch 'master' into messaging-10625
russellwheatley 99b3f08
Merge branch 'master' into messaging-10625
russellwheatley File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @kevinthecheung - documentation update that could do with a review, please 😄