docs(firebase_auth): Update firebase_auth.dart to add more info about the error codes #12195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error codes is not very clear, the way that firebase SDK handles the errors is not the best, using sealed classes or enum class is more efficient, also I found some bugs **INVALID_LOGIN_CREDENTIALS** or **invalid-credential**: Depending on if we are using firebase emulator or the production cloud project some error codes thrown differently even though it's the exact same error I add some important errors and not all of them, I can add more
ellet0
changed the title
|
The format code can be easily solved, the question is should this PR merged or rejected? in either case I still think the error handling could be improved a lot in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The error codes is not very clear, the way that firebase SDK handles the errors is not the best, using sealed classes or enum class is more efficient, also I found some bugs
INVALID_LOGIN_CREDENTIALS or invalid-credential: Depending on if we are using firebase emulator or the production cloud project some error codes thrown differently even though it's the exact same error
I add some important errors and not all of them, I can add more
Related Issues
There is no related issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?