Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage, windows): putFile(), putString(), putData() & Task streaming event fixes #12723

Merged
merged 24 commits into from
May 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
04dd427
fix(storage, windows): putString & putData API fixes
russellwheatley Apr 29, 2024
ee3b6b8
fix: decoding base64 for putString
russellwheatley Apr 30, 2024
219831c
remove spacing
russellwheatley Apr 30, 2024
223d1fe
chore: update naming convention to keep the same
russellwheatley Apr 30, 2024
81258a9
test: skip test to be fixed later
russellwheatley Apr 30, 2024
6c12fdd
fix: putFile metadata
russellwheatley Apr 30, 2024
e4d8dbf
fix(windows): putFile null metadata throw exception on windows
russellwheatley May 1, 2024
973a62e
fix: return customMetadata
russellwheatley May 1, 2024
78286c9
fix: set metadata
russellwheatley May 1, 2024
acbf9c4
reference e2e tests now working
russellwheatley May 1, 2024
9d1e6c2
fix: data encoding from windows to dart
russellwheatley May 1, 2024
3859bf1
fix: onProgress and onPaused snapshot listeners
russellwheatley May 1, 2024
3333ee4
fix: error handling when streaming events
russellwheatley May 2, 2024
d8ca29f
test(storage): update e2e tests for windows
russellwheatley May 2, 2024
839ed39
chore: analyse + format
russellwheatley May 3, 2024
987eb09
test: update e2e tests to check content is correctly written
russellwheatley May 10, 2024
894cd29
fix: windows core sending empty strings back to flutter
russellwheatley May 10, 2024
44de7bc
test: reinstate failing test after fix
russellwheatley May 10, 2024
d4d0329
fix: pass bucket back with metadata, pass path back with snapshot
russellwheatley May 10, 2024
662b273
test(storage): reinsert 2nd storage bucket
russellwheatley May 10, 2024
4dcccf4
test: reinsert test
russellwheatley May 10, 2024
0541f7f
chore: update comment
russellwheatley May 10, 2024
957472a
fix format
russellwheatley May 10, 2024
346be59
rm unused import
russellwheatley May 10, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -79,14 +79,19 @@ PigeonFirebaseOptions optionsFromFIROptions(
PigeonFirebaseOptions pigeon_options = PigeonFirebaseOptions();
pigeon_options.set_api_key(options.api_key());
pigeon_options.set_app_id(options.app_id());
if (options.database_url() != nullptr) {
pigeon_options.set_database_u_r_l(options.database_url());
// AppOptions initialises as empty char so we check to stop empty string to
// Flutter Same for storage bucket below
const char *db_url = options.database_url();
if (db_url != nullptr && db_url[0] != '\0') {
pigeon_options.set_database_u_r_l(db_url);
}
pigeon_options.set_tracking_id(nullptr);
pigeon_options.set_messaging_sender_id(options.messaging_sender_id());
pigeon_options.set_project_id(options.project_id());
if (options.storage_bucket() != nullptr) {
pigeon_options.set_storage_bucket(options.storage_bucket());

const char *storage_bucket = options.storage_bucket();
if (storage_bucket != nullptr && storage_bucket[0] != '\0') {
pigeon_options.set_storage_bucket(storage_bucket);
}
return pigeon_options;
}
Expand Down