Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, ios): fix document stream handler options. #12763

Closed
wants to merge 2 commits into from

Conversation

PJakubec
Copy link

@PJakubec PJakubec commented May 9, 2024

Description

On an iOS device, using includeMetadataChanges does not work stream correct metadata events for single document snapshots.
These events are not handled correctly:

  • First query execution (works correctly on first app launch [because data is not yet in cache, but any subsequent launch will be handled incorrectly])
  • Regaining/Losing connection to the database

Related Issues

Fixes: #12761

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

google-cla bot commented May 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@TarekkMA
Copy link
Contributor

TarekkMA commented May 9, 2024

Please sign the google cla

@TarekkMA TarekkMA changed the title feat(cloud_firestore, ios): DocumentSnapshotStreamHandler was not correctly listening on metadata changes fix(firestore, ios): fix document stream handler options. May 9, 2024
@PJakubec PJakubec changed the title fix(firestore, ios): fix document stream handler options. feat(cloud_firestore, ios): DocumentSnapshotStreamHandler was not correctly listening on metadata changes May 10, 2024
@PJakubec PJakubec changed the title feat(cloud_firestore, ios): DocumentSnapshotStreamHandler was not correctly listening on metadata changes fix(firestore, ios): fix document stream handler options. May 10, 2024
@PJakubec
Copy link
Author

My employer did sign the CLA yesterday and added me to the relevant google group.
Looking at the CLA Troubleshooting Page (https://opensource.google/documentation/reference/cla#troubleshoot), I guess it is waiting for Google to validate the request:

If the contributor is covered by a corporate CLA, make sure that the corporation is listed at http://linkremoved/. If it's not, it simply may not have been processed yet, which typically takes a few days.

After the request is entered in the system, the CLA is sent via DocuSign to an authorized signer at the company. Once that's signed, it's sent back to Google for validation and cross-signing.

@TarekkMA TarekkMA closed this May 13, 2024
@firebase firebase locked and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants