Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_analytics): fixed type assertion that ignored nullable fields #12792

Conversation

jorgecoca
Copy link

@jorgecoca jorgecoca commented May 16, 2024

Description

In Firebase Analytics, when passing parameters to logPurchase, the signature allows for nullable values (Map<String, Object?>?). However, down the line, there is a method called _assertParameterTypesAreCorrect that asserts value types but ignored null values, creating a runtime issue.

More details in #12790

Related Issues

Fixes #12790

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@jorgecoca jorgecoca closed this May 17, 2024
@jorgecoca jorgecoca deleted the fix/firebase-analytics-null-pointer branch May 17, 2024 14:37
@firebase firebase locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_analytics]: logPurchase crashes when any of the values inside parameters is null
1 participant