Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth, apple): bug with cached AuthCredential, hash key was producing different value #12957

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 13, 2024

Description

Invoking this @([authCredential hash]) produce two different hash keys which meant we were unable to retrieve from cache if the user linkWithCredential() threw exception "credential-already-in-use" containing a credential to sign-in with.

This change ensures the same hash key is used to retrieve the exception in native code to allow signInWithCredential().

Both users confirmed it is working.

Related Issues

fixes #12931

fixes: #12944

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title fix(auth, apple): bug with cached authCredential, hash key was producing different value fix(auth, apple): bug with cached AuthCredential, hash key was producing different value Jun 13, 2024
@russellwheatley russellwheatley merged commit ef0077e into master Jun 13, 2024
25 of 26 checks passed
@russellwheatley russellwheatley deleted the auth-12931 branch June 13, 2024 17:01
@firebase firebase locked and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants