Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update documentation for auth/user-not-found exception to reflect email enumeration protection #12964

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

xemexpress
Copy link
Contributor

Description

This pull request updates the documentation for the auth/user-not-found exception in the firebase_auth.dart file. The update reflects the recent change where email enumeration protection is enabled by default as of September 15, 2023. With this protection, the auth/user-not-found exception is no longer thrown if the account with the specified email does not exist.

Changes made:

  • Updated the documentation to include a note about the email enumeration protection.
  • Clarified the conditions under which the auth/user-not-found exception is thrown.

This change ensures that developers are aware of the new behavior and can handle authentication flows accordingly.

Copy link

google-cla bot commented Jun 16, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@xemexpress xemexpress changed the title Update documentation for auth/user-not-found exception to reflect email enumeration protection docs: Update documentation for auth/user-not-found exception to reflect email enumeration protection Jun 16, 2024
@xemexpress
Copy link
Contributor Author

Our change is documentation-only. Shouldn't it affect tests? Any guidance on the failing tests please?

@Lyokone Lyokone merged commit 125f820 into firebase:master Jun 25, 2024
16 of 20 checks passed
@Lyokone
Copy link
Contributor

Lyokone commented Jun 25, 2024

Some tests can be flaky, it looks good tho, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants