Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firebase_crashlytics): Add Flutter dependency to podspec #5455

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

jmagman
Copy link
Contributor

@jmagman jmagman commented Mar 24, 2021

Description

flutter/flutter#78592 stopped trying Flutter against pods that don't explicitly declare Flutter as a dependency (to fix a bitcode linking issue). This means that all Flutter plugins rely on correct podspec dependencies set up, so either s.dependency 'Flutter' or s.dependency 'FlutterMacOS'.

I don't see any other podspecs that are missing it.

Related Issues

Fixes #5440

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@jmagman jmagman self-assigned this Mar 24, 2021
@google-cla google-cla bot added the cla: yes label Mar 24, 2021
@jmagman jmagman requested a review from Salakar March 24, 2021 21:45
@Salakar Salakar merged commit 07f33d1 into firebase:master Mar 24, 2021
@Salakar
Copy link
Member

Salakar commented Mar 24, 2021

Thank you

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [firebase_crashlytics] 'Flutter/Flutter.h' file not found
2 participants