Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies (firebase-functions v4 and others) #1024

Merged
merged 13 commits into from
Nov 9, 2022
Merged

Update dependencies (firebase-functions v4 and others) #1024

merged 13 commits into from
Nov 9, 2022

Conversation

jhuleatt
Copy link
Collaborator

@jhuleatt jhuleatt commented Nov 3, 2022 •
edited
Loading

  • fix CI, add some samples to pnpm workspace that weren't being compiled/tested
  • update firebase-functions, firebase-admin, firebase-functions-test to latest versions
  • remove deprecated dependencies, update dependencies where possible
  • replace all HTTP fetch libraries (request, request-promise, axios) with node-fetch, in anticipation of the fetch API becoming a part of Node after Node 16

@jhuleatt jhuleatt marked this pull request as ready for review November 4, 2022 12:36
@jhuleatt jhuleatt requested review from egilmorez and taeold and removed request for egilmorez November 4, 2022 12:36
@jhuleatt
Copy link
Collaborator Author

jhuleatt commented Nov 4, 2022

Sorry for the monster PR. I'm mostly looking for a rubber-stamp approval so that the repo can have updated deps and a working CI again.

egilmorez
egilmorez approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

102 files! I looked at a bunch of them, but mainly I'm going to trust you.

@jhuleatt jhuleatt merged commit 81700d7 into main Nov 9, 2022
@Mistrz82 Mistrz82 linked an issue Mar 12, 2023 that may be closed by this pull request
[BUG] in sample: #1053
Closed
@Mistrz82 Mistrz82 removed a link to an issue Mar 12, 2023
[BUG] in sample: #1053
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egilmorez egilmorez egilmorez approved these changes

@kaibolay kaibolay kaibolay approved these changes

@taeold taeold Awaiting requested review from taeold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhuleatt @egilmorez @kaibolay