-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to firebase v9 modular sdk #243
Conversation
@puf this is ready for review. Please use "Squash and Merge" when you merge it. |
@@ -42,15 +42,15 @@ | |||
"geofire-common": "5.2.0" | |||
}, | |||
"peerDependencies": { | |||
"firebase": "^2.4.0 || 3.x.x || 4.x.x || 5.x.x || 6.x.x || 7.x.x || 8.x.x" | |||
"firebase": "9.x.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still a bit sad about losing so much compatibility, but I guess having a /compat
path might be a bridge too far here. Folks on older/compat versions of the JS SDK should stick to the older geofire-js release, since that hasn't changed significantly in years anyway. Should we mention that in the README?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added it to the migration guide here: thatfiredev@654fb00
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit from me, and a potential improvement to the docs. With those, this LGTM
Description
This PR should update geofire to use the new modular firebase sdk (v9).
I simply copied the changes from #217 and made small improvements with as little code changes as possible to fix the build. These include:
uglify
plugin withterser
TODO:
Code sample