Miscellaneous cleanup #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ | |||
| * | |||
| * @constructor | |||
| * @this {GeoCallbackRegistration} | |||
| * @param {function} cancelCallback Callback to run when this callback registration is cancelled. | |||
| * @param {Function} cancelCallback Callback to run when this callback registration is cancelled. | |||
There was a problem hiding this comment.
I think JSDoc uses lowercase for built in types [1](which refers to [2]). The same also counts for number, string and boolean. Anything I'm missing here?
[1] http://usejsdoc.org/tags-type.html
[2] https://developers.google.com/closure/compiler/docs/js-for-compiler#types
There was a problem hiding this comment.
Nope, I just dropped the ball on the whole JSDoc compliance thing. I just pushed fixes for everything after finally reading their docs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jdimond - please review and merge.
Hat-tip to @mikepugh for the inspiration for both of these items. I especially like the
catch()addition to the test suite, Mike!