feat: add ed25519 support to JWK (public keys) #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edudobay
force-pushed
the
add-ed25519-jwk-support
branch
from
8d0e319
to
9fdf25d
Compare
Reference documentation: https://datatracker.ietf.org/doc/html/rfc8037
edudobay
force-pushed
the
add-ed25519-jwk-support
branch
from
9fdf25d
to
6d61880
Compare
edudobay
commented
Apr 4, 2022
|
This is great! Thank you for submitting this! I'll take a look. I think for my base PR and this PR also, I'd like more robust testing cases. I am not sure how solid the code I wrote is... for instance, I was able to find cases where verification failed and I'm not sure why. If you're up to it, and can review #399, that would help a lot! |
|
Hi @bshaffer! Sorry I've taken so long to reply. Is there anything I can do to make this mergeable? I'm not sure why this PR was closed. If you'd like any further help let me know. |
|
Hi @edudobay This PR was closed automatically because I merged and deleted the |
This was referenced Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #399 to support parsing JWK ed25519 keys.
Reference documentation: RFC8037