Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(admob, analytics): replace deprecated methods #1176

Merged

Conversation

thatfiredev
Copy link
Member

@thatfiredev thatfiredev commented Sep 17, 2020

This PR should replace 2 deprecated methods:

  1. MobileAds.initialize() in the admob sample app;
  2. FirebaseAnalytics.setCurrentScreen() in the analytics sample app.

Worth pointing out that the analytics snippet is shown in the Documentation and a change may be in order to remove this last line bellow the snippet:

Screenshot from 2020-09-17 19-53-19

@samtstern samtstern merged commit 2fc7c6b into firebase:master Sep 24, 2020
@thatfiredev thatfiredev deleted the rpf-analytics-admob-deprecations branch September 24, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants