-
Notifications
You must be signed in to change notification settings - Fork 7.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
suggested change #1186
suggested change #1186
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@Chitvan14 thanks for the PR but we don't say "Google Firebase", just Firebase! |
@samtstern I feel like this is just a PR to +1 their PR count on Hacktoberfest. I would suggest labelling it as "invalid" to discourage other participants from doing the same. Context: https://hacktoberfest.digitalocean.com/hacktoberfest-update @Chitvan14 please take some time to read the Hacktoberfest Quality Guidelines. |
@rosariopfernandes I sort of suspected that but didn't want to accuse anyone! Agree, if this is related to Hacktoberfest it's not within the guidelines. |
Hey ,
My intention was not to take part in hacktoberfest but I usually listened
Google firebase before...so when I come up with your repo...I found that
missing...and seemed to add that...but after @samtstern reply to me I came
to know that we can also recall Google firebase as only firebase...
@samtstern Thank you for letting me learn
@rosariopfernandes I am sorry if you feel it was an action of netiquette
…On Fri, Oct 2, 2020, 7:00 PM Rosário Pereira Fernandes < ***@***.***> wrote:
@samtstern <https://github.com/samtstern> I feel like this is just a PR
to +1 their PR count on Hacktoberfest. I would suggest labelling it as
"invalid" to discourage other participants from doing the same. Context:
https://hacktoberfest.digitalocean.com/hacktoberfest-update
I fear we'll be getting many of these throughout the month.
------------------------------
@Chitvan14 <https://github.com/Chitvan14> please take some time to read
the Hacktoberfest Quality Guidelines
<https://hacktoberfest.digitalocean.com/details#quality>.
A better way to contribute to Open Source is too look at the Repo's Issue
Tracker and see what they actually need, instead of trying to make
documentation changes which don't really add much to the project.
Some resources that you might find useful:
- Hacktoberfest - Ideas for Contributing as a Beginner
<https://dev.to/mcastellin/hacktoberfest-ideas-for-contributing-as-a-beginner-4k3b>
- Hacktoberfest Etiquette for Contributors
<https://dev.to/devteam/hacktoberfest-etiquette-for-contributors-ec6>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1186 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKSZLVTDHFTY3DRYMMJ56R3SIXIXHANCNFSM4SBVV5CQ>
.
|
@Chitvan14 no worries! |
@Chitvan14 no problems. I'm glad you understand our concern. I'm sorry for the false accusation. |
No description provided.