Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggested change #1186

Closed
wants to merge 1 commit into from
Closed

suggested change #1186

wants to merge 1 commit into from

Conversation

Chitvan14
Copy link

No description provided.

@google-cla
Copy link

google-cla bot commented Oct 2, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@samtstern
Copy link
Contributor

@Chitvan14 thanks for the PR but we don't say "Google Firebase", just Firebase!

@samtstern samtstern closed this Oct 2, 2020
@thatfiredev
Copy link
Member

thatfiredev commented Oct 2, 2020

@samtstern I feel like this is just a PR to +1 their PR count on Hacktoberfest. I would suggest labelling it as "invalid" to discourage other participants from doing the same. Context: https://hacktoberfest.digitalocean.com/hacktoberfest-update
I fear we'll be getting many of these throughout the month.


@Chitvan14 please take some time to read the Hacktoberfest Quality Guidelines.
A better way to contribute to Open Source is to look at the Repo's Issue Tracker and see what they actually need, instead of trying to make documentation changes which don't really add much to the project.
Some resources that you might find useful:

@samtstern
Copy link
Contributor

@rosariopfernandes I sort of suspected that but didn't want to accuse anyone! Agree, if this is related to Hacktoberfest it's not within the guidelines.

@Chitvan14
Copy link
Author

Chitvan14 commented Oct 2, 2020 via email

@samtstern
Copy link
Contributor

@Chitvan14 no worries!

@thatfiredev
Copy link
Member

@Chitvan14 no problems. I'm glad you understand our concern. I'm sorry for the false accusation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants