Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RelativeLayout from Firestore quickstart #1245

Merged
merged 7 commits into from
Jan 12, 2021
Merged

Remove RelativeLayout from Firestore quickstart #1245

merged 7 commits into from
Jan 12, 2021

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jan 12, 2021 •
edited

See #1217

activity_main

Before After
Screen Shot 2021-01-12 at 1 32 48 PM Screen Shot 2021-01-12 at 1 49 18 PM

activity_restaurant

Before After
Screen Shot 2021-01-12 at 1 56 15 PM Screen Shot 2021-01-12 at 2 09 56 PM

dialog_filters

Before After
Screen Shot 2021-01-12 at 2 11 41 PM Screen Shot 2021-01-12 at 2 29 07 PM

dialog_rating

Before After
Screen Shot 2021-01-12 at 2 31 02 PM Screen Shot 2021-01-12 at 2 34 21 PM

item_rating

Before After
Screen Shot 2021-01-12 at 2 36 07 PM Screen Shot 2021-01-12 at 2 39 58 PM

item_restaurant

Before After
Screen Shot 2021-01-12 at 2 41 33 PM Screen Shot 2021-01-12 at 2 46 55 PM

@samtstern
activity_main
0967bf7 
Change-Id: I377908ce210b926fcefc1770d3fc8f23a485e052
@samtstern
activity_restaurant
fe9a3f1 
Change-Id: Ie4e5c0df50577d3a525761c19d5a21d655ffce8f
@samtstern
dialog_filters
cdfa45a 
Change-Id: I89dda983a4224508e98cbc06084b36b24809ca4e
@samtstern
dialog_rating
b5af2c8 
Change-Id: Id49a1bf7b21f9519ba2d1729902eabb175de4149
@samtstern
item_rating
37e5aef 
Change-Id: I9ad2addd30326bcc8495ae1bcfc4eacc68800733
@samtstern
item_restaurant
46bfbc5 
Change-Id: I649f645dff2963c1e0e92aef0092c7ab4141fd4c
@samtstern samtstern marked this pull request as ready for review January 12, 2021 14:48
@samtstern
Copy link
Contributor Author

@rosariopfernandes please take a look when you get a chance!

@samtstern samtstern mentioned this pull request Jan 12, 2021
Closed
16 tasks
@samtstern
Some more cleanup
d94cf07 
Change-Id: I1befd55d9c41b3ef5ac72bbd81022f06b9e2488c
thatfiredev
thatfiredev approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@thatfiredev thatfiredev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samtstern samtstern merged commit 368ff73 into master Jan 12, 2021
@samtstern samtstern added this to the jetpack milestone Jan 12, 2021
@snyk-bot snyk-bot mentioned this pull request Oct 22, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 6, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Dec 31, 2022
Open
@NOUIY NOUIY mentioned this pull request Jan 12, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 22, 2023
Open
@NOUIY NOUIY mentioned this pull request Jan 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Jan 29, 2023
Open
@NOUIY NOUIY mentioned this pull request Feb 24, 2023
Open
@snyk-bot snyk-bot mentioned this pull request Apr 26, 2023
Open
@NOUIY NOUIY mentioned this pull request May 13, 2023
Open
@snyk-bot snyk-bot mentioned this pull request May 14, 2023
Open
@NOUIY NOUIY mentioned this pull request Jun 24, 2023
Open
@Kryslynn93 Kryslynn93 mentioned this pull request Aug 16, 2023
Open
@NOUIY NOUIY mentioned this pull request Aug 23, 2023
Open
This was referenced Sep 1, 2023
Open
Open
@NOUIY NOUIY mentioned this pull request Sep 16, 2023
Open
This was referenced Sep 17, 2023
Open
Open
This was referenced Sep 26, 2023
Open
Open
@NOUIY NOUIY mentioned this pull request Oct 4, 2023
Open
This was referenced Oct 14, 2023
Open
Open
Open
Open
@NOUIY NOUIY mentioned this pull request Oct 21, 2023
Open
This was referenced Nov 7, 2023
Open
Open
This was referenced Nov 21, 2023
Open
Open
@Hawthorne001 Hawthorne001 mentioned this pull request Feb 21, 2024
Open
@NOUIY NOUIY mentioned this pull request Mar 28, 2024
Open
@RMSPORTS1902 RMSPORTS1902 mentioned this pull request Apr 30, 2024
Open
@thatfiredev thatfiredev deleted the ss-firestore-constraint branch May 3, 2024 00:23
@Kryslynn93 Kryslynn93 mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatfiredev thatfiredev thatfiredev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
jetpack
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samtstern @thatfiredev