Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new sample for MLKit Language ID. #797

Merged
merged 3 commits into from Feb 1, 2019
Merged

Add new sample for MLKit Language ID. #797

merged 3 commits into from Feb 1, 2019

Conversation

gkaldev
Copy link
Contributor

@gkaldev gkaldev commented Jan 31, 2019

No description provided.

Change-Id: I95589f620be6fa3741c244bf37d77832a1e5d33c
Change-Id: I76446529396f4e1f0dc8844c3f6c73624c2349a3
Change-Id: I72cc24a0a376a251b4a94966d529fbc86ef39b0f
@gkaldev
Copy link
Contributor Author

gkaldev commented Jan 31, 2019

@samtstern as FYI. Already went through internal review.

@gkaldev gkaldev merged commit b851c66 into firebase:master Feb 1, 2019
val inputText = findViewById<TextInputEditText>(R.id.input_text)
val idLanguageButton = findViewById<Button>(R.id.button_id_language)
val findAllButton = findViewById<Button>(R.id.button_id_all)
outputText = findViewById(R.id.output_text)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use Kotlin Extensions here instead of findViewById?

cc: @samtstern

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #799

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants