refactor: remove unused libraries #980

thatfiredev · 2019-10-24T22:43:05Z

The initial idea here was to remove the legacy support library, since it seems like it is not being used anywhere in the code. But then I noticed that if we use the Material Components Theme, we might be able to remove some other libraries as well, such as androidx.cardview:cardview:1.0.0.

I was wondering if this is something we're interested in? If it is, I can do it to the remaining samples on this same PR.

samtstern

@rosariopfernandes just a few small questions but in general I am a fan of this!

functions/app/src/main/AndroidManifest.xml

functions/app/src/main/res/layout/activity_main.xml

note that this might cause runtime errors if the modules implementing chooserx are still using AppTheme

thatfiredev · 2019-10-25T18:25:14Z

thatfiredev · 2019-10-28T13:18:20Z

mlkit-langid/app/src/main/res/layout/activity_main.xml

@@ -25,7 +25,7 @@
            android:hint="@string/help_text" />
    </com.google.android.material.textfield.TextInputLayout>

-    <androidx.constraintlayout.Guideline
+    <androidx.constraintlayout.widget.Guideline


The previous implementation was causing the app to crash on start. Seems like there was a breaking change on the latest version of ConstraintLayout. Found this solution on StackOverflow

samtstern · 2019-11-04T17:44:09Z

@rosariopfernandes just let me know when you're ready for review! Doesn't have to be 100% done you can always do RTDB and MLKit in a follow-up

thatfiredev · 2019-11-04T20:23:24Z

Thanks @samtstern , but I've already done both of them.
This is ready for review now.

thatfiredev · 2019-11-04T20:36:34Z

auth/app/src/main/java/com/google/firebase/quickstart/auth/kotlin/ChooserActivity.kt

@@ -34,7 +34,7 @@ class ChooserActivity : AppCompatActivity(), AdapterView.OnItemClickListener {
        setContentView(R.layout.activity_chooser)

        // Set up Adapter
-        val adapter = MyArrayAdapter(this, android.R.layout.simple_list_item_2, CLASSES)
+        val adapter = MyArrayAdapter(this, android.R.layout.simple_list_item_2, CLASSES as Array<Class<*>>)


This is unrelated, but Android Studio was showing an error saying it expected Array<Class<*>>, but found Array<out Class<out Any>>.

This reverts commit 8406d88

thatfiredev · 2019-11-04T23:08:15Z

analytics/app/src/main/java/com/google/firebase/quickstart/analytics/java/MainActivity.java

        public ImagePagerAdapter(FragmentManager fm, ImageInfo[] infos) {
-            super(fm);
+            super(fm, BEHAVIOR_RESUME_ONLY_CURRENT_FRAGMENT);


Added the constant to match its Kotlin equivalent

thatfiredev · 2019-11-04T23:10:09Z

analytics/app/src/main/java/com/google/firebase/quickstart/analytics/kotlin/MainActivity.kt

@@ -218,6 +219,7 @@ class MainActivity : AppCompatActivity() {
     * A [FragmentPagerAdapter] that returns a fragment corresponding to
     * one of the sections/tabs/pages.
     */
+    @SuppressLint("WrongConstant")


Added this to ignore Lint message:

Must be one of: androidx.fragment.app.FragmentPagerAdapter.BEHAVIOR_RESUME_ONLY_CURRENT_FRAGMENT or androidx.fragment.app.FragmentPagerAdapter.BEHAVIOR_SET_USER_VISIBLE_HINT

samtstern · 2019-11-04T23:50:49Z

@rosariopfernandes thank you SO much for doing all this! LGTM if it builds.

thatfiredev added 8 commits May 7, 2019 23:37

fix: add mock-google-services.json to mlkit-translate during build

e9e4fe8

fix: add mock-google-services.json to mlkit-translate during build

bcacb38

Merge branch 'master' of https://github.com/firebase/quickstart-android

0dc9dc1

Merge branch 'master' of https://github.com/firebase/quickstart-android

77f3aae

Merge branch 'master' of https://github.com/firebase/quickstart-android

e6e6d7c

[functions] use Material Theme instead of AppCompat

e73d3e5

[functions] remove unused libraries

49b38d8

[firestore] remove unused legacy support library

d34e178

samtstern reviewed Oct 25, 2019

View reviewed changes

functions/app/src/main/AndroidManifest.xml Outdated Show resolved Hide resolved

functions/app/src/main/res/layout/activity_main.xml Show resolved Hide resolved

thatfiredev added 7 commits October 25, 2019 19:45

[chooserx] AppCompat -> MaterialComponents

ab79df1

note that this might cause runtime errors if the modules implementing chooserx are still using AppTheme

[firestore] AppCompat -> MaterialComponents

357a502

[admob] AppCompat -> MaterialComponents

03b2934

[analytics] AppCompat -> MaterialComponents

a7dfa37

[app-indexing] AppCompat -> MaterialComponents

41f93bd

[perfmon] AppCompat -> MaterialComponents

2833c7e

[inappmessaging] AppCompat -> MaterialComponents

f120d9d

thatfiredev added 3 commits October 28, 2019 14:55

[mlkit-translate] remove appcompat and legacy-support libraries

c1d0e27

[mlkit-smartreply] remove appcompat and legacy-support libraries

a6d0620

[mlkit-langid] AppCompat -> MaterialComponents

8d0ebf5

thatfiredev commented Oct 28, 2019

View reviewed changes

thatfiredev added 7 commits October 28, 2019 23:52

[remote-config] AppCompat -> MaterialComponents

237fdd9

[crashlytics] AppCompat -> MaterialComponents

5e6bcc3

[dynamiclinks] AppCompat -> MaterialComponents

499b912

[messaging] AppCompat -> MaterialComponents

318c590

[storage] AppCompat -> MaterialComponents

86d2218

[auth] AppCompat -> MaterialComponents

81f90ab

Merge branch with master

0afb5e6

[mlkit] AppTheme -> MaterialComponents

518ed47

[rtdb] AppTheme -> MaterialComponents

87dc41e

thatfiredev marked this pull request as ready for review November 4, 2019 20:23

[analytics] fix: update fragment dependency

8406d88

thatfiredev commented Nov 4, 2019

View reviewed changes

thatfiredev added 2 commits November 5, 2019 00:47

Revert "[analytics] fix: update fragment dependency"

dd9bb1d

This reverts commit 8406d88

[analytics] keep appcompat dependency to use FragmentPagerAdapter

b01c522

thatfiredev commented Nov 4, 2019

View reviewed changes

[rtdb] keep appcompat dependency to use FragmentPagerAdapter

1623a8f

thatfiredev force-pushed the rpf.remove-unused-libraries branch from 610928d to 1623a8f Compare November 4, 2019 23:33

[rtdb] keep appcompat dependency to use FragmentPagerAdapter

fd1d87a

samtstern approved these changes Nov 4, 2019

View reviewed changes

samtstern merged commit a722aee into firebase:master Nov 4, 2019

thatfiredev deleted the rpf.remove-unused-libraries branch April 3, 2020 11:09

snyk-bot mentioned this pull request Jan 17, 2022

[Snyk] Upgrade firebase-functions from 3.11.0 to 3.16.0 majacQ/quickstart-android#9

Open

snyk-bot mentioned this pull request Feb 21, 2022

[Snyk] Upgrade firebase-functions from 3.11.0 to 3.16.0 NOUIY/quickstart-android#2

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove unused libraries #980

refactor: remove unused libraries #980

thatfiredev commented Oct 24, 2019 •

edited

samtstern left a comment

thatfiredev commented Oct 25, 2019 •

edited

thatfiredev Oct 28, 2019

samtstern commented Nov 4, 2019

thatfiredev commented Nov 4, 2019

thatfiredev Nov 4, 2019

thatfiredev Nov 4, 2019

thatfiredev Nov 4, 2019

samtstern commented Nov 4, 2019

refactor: remove unused libraries #980

refactor: remove unused libraries #980

Conversation

thatfiredev commented Oct 24, 2019 • edited

samtstern left a comment

Choose a reason for hiding this comment

thatfiredev commented Oct 25, 2019 • edited

Progress Tracking:

thatfiredev Oct 28, 2019

Choose a reason for hiding this comment

samtstern commented Nov 4, 2019

thatfiredev commented Nov 4, 2019

thatfiredev Nov 4, 2019

Choose a reason for hiding this comment

thatfiredev Nov 4, 2019

Choose a reason for hiding this comment

thatfiredev Nov 4, 2019

Choose a reason for hiding this comment

samtstern commented Nov 4, 2019

thatfiredev commented Oct 24, 2019 •

edited

thatfiredev commented Oct 25, 2019 •

edited