Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depreciated method - please update documentation #280

Closed
wuujcik opened this issue Feb 22, 2021 · 6 comments
Closed

Depreciated method - please update documentation #280

wuujcik opened this issue Feb 22, 2021 · 6 comments

Comments

@wuujcik
Copy link

wuujcik commented Feb 22, 2021

// Create and launch sign-in intent
startActivityForResult(
AuthUI.getInstance()
.createSignInIntentBuilder()
.setAvailableProviders(providers)
.build(),
RC_SIGN_IN)
// [END auth_fui_create_intent]

startActivityForResult(Intent,int) is deprecated, please update your snippet and documentation

@samtstern
Copy link
Contributor

Thanks for the feedback @wuujcik! As far as I know the startActivityForResult() method is not actually deprecated:
https://developer.android.com/reference/android/app/Activity#startActivityForResult(android.content.Intent,%20int)

Although you're correct that it's no longer recommended:
https://developer.android.com/training/basics/intents/result

I think what we need to do here is ship an ActivityResultContract in the FirebaseUI library which would enable developers to safely use the shiny new API!

@thatfiredev
Copy link
Member

@samtstern the startActivityForResult and onActivityResult methods have been deprecated in the androidx.activity library v1.2.0. I only see deprecation warnings in projects using that library.

@wuujcik Thanks for bringing this up. As @samtstern mentioned, this should be done in the FirebaseUI library and might come out in the next release of that library (see firebase/FirebaseUI-Android#1918 )

@kolaviswanath
Copy link

// Create and launch sign-in intent
startActivityForResult(
AuthUI.getInstance()
.createSignInIntentBuilder()
.setAvailableProviders(providers)
.build(),
RC_SIGN_IN)
// [END auth_fui_create_intent]

startActivityForResult(Intent,int) is deprecated, please update your snippet and documentation

Delete

@aditmodhvadia
Copy link

Any updates on the deprecation of startActivityForResult()?

@thatfiredev
Copy link
Member

I think this has been solved by #303

@samtstern
Copy link
Contributor

@rosariopfernandes thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants