Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Complete kotlinization #48

Merged
merged 10 commits into from Sep 13, 2018
Merged

[WIP] Complete kotlinization #48

merged 10 commits into from Sep 13, 2018

Conversation

samtstern
Copy link
Contributor

In this PR:

  • Write all missing Kotlin snippets
  • Make file names more parallel
  • Add a script to enforce snippet parity

Change-Id: If5ffcf37bee36eb1ef9f2e62647c17630ba50e30
Change-Id: I61f092b5f86f334fb755f55a65c280ce6ce93dfb
Change-Id: If37d076f3531eaf1caac36f5bcfb21cf338c853c
Change-Id: I18486c4102cf11b44017078f8d07a4feefb9aa37
Change-Id: If17adb6e27fc92d785ceb8845a853b82e8739e6d
Change-Id: Icda8a2fd3149f7dee85d9ab7d20706cacd67cbc4
Change-Id: Iade302bbc8516375ebbdc709b50271f2be4923f8
Change-Id: I59ccb26e9e6132acc466227601ff345700c70c02
@samtstern
Copy link
Contributor Author

Woo it works! Build failed for missing snippet:
image

Change-Id: I480b55ed78bc75fa2a9355881e11152a201527b7
Change-Id: I9cc679e29284c71f72929617cc78bec720d343c3
@samtstern
Copy link
Contributor Author

@rosariopfernandes FYI I made a script to find any Java file that does not have a matching Kotlin file, or one where the Java file contains snippets that are not in the Kotlin file.

I think we should be able to delete all the interfaces after this, since we were only using them to enforce snippet parity. WDYT?

@thatfiredev
Copy link
Member

Wow, that's awesome! Deleting the interfaces sounds good to me.

@samtstern
Copy link
Contributor Author

Gonna merge this and then do a separate CL to figure out interfaces and fix the Kotlin code style.

@samtstern samtstern merged commit 70db4c0 into master Sep 13, 2018
@samtstern samtstern deleted the ss-kotlin-complete branch October 17, 2018 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants