Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be clear more clear about results of enablePersistence() #9

Merged
merged 1 commit into from Aug 9, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 1 addition & 4 deletions firestore/test.firestore.js
Expand Up @@ -24,10 +24,6 @@ describe("firestore", () => {
);

firebase.firestore().enablePersistence()
.then(function() {
// Initialize Cloud Firestore through firebase
var db = firebase.firestore();
})
.catch(function(err) {
if (err.code == 'failed-precondition') {
// Multiple tabs open, persistence can only be enabled
Expand All @@ -39,6 +35,7 @@ describe("firestore", () => {
// ...
}
});
// Subsequent queries will use persistence, if it was enabled successfully
// [END initialize_persistence]
});

Expand Down