Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix now() tests #113

Merged
merged 2 commits into from
Dec 6, 2023
Merged

test: Fix now() tests #113

merged 2 commits into from
Dec 6, 2023

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Dec 6, 2023

Description

NOW() function now returns TIMESTAMPTZ, same as postgres. Changing tests to verify the new behaviour.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

@ptiurin ptiurin changed the title feat: Firebolt backwards compatibility (#112) test: Fix now() tests Dec 6, 2023
Copy link

sonarcloud bot commented Dec 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.14) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ptiurin
Copy link
Collaborator Author

ptiurin commented Dec 6, 2023

Integration tests passing, as seen in checks with only one test failing. The underlying issue has been fixed on the backend in https://packboard.atlassian.net/browse/FIR-28289 and I'm waiting for that engine version to be deployed in stg.

@ptiurin ptiurin marked this pull request as ready for review December 6, 2023 14:42
@ptiurin ptiurin requested a review from a team as a code owner December 6, 2023 14:42
@ptiurin ptiurin merged commit 3ed69d9 into main Dec 6, 2023
8 of 10 checks passed
@ptiurin ptiurin deleted the test-fix-now branch December 6, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants