Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Remove Python 3.7 support #119

Merged
merged 2 commits into from
Feb 1, 2024
Merged

build: Remove Python 3.7 support #119

merged 2 commits into from
Feb 1, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Jan 26, 2024 •
edited

Description

Removing 3.7 support as described in DBT 1.6 guidelines.

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 31, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ptiurin
Copy link
Collaborator Author

ptiurin commented Jan 31, 2024

Waiting for fix in firebolt-db/jaffle_shop_firebolt#16 to properly test this. Looks good locally.

@ptiurin ptiurin marked this pull request as ready for review January 31, 2024 17:55
@ptiurin ptiurin requested a review from a team as a code owner January 31, 2024 17:55
@ptiurin ptiurin merged commit 2530415 into main Feb 1, 2024
8 of 12 checks passed
@ptiurin ptiurin deleted the build-remove-3.7-support branch February 1, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ptiurin @stepansergeevitch