Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1.6-compatibility stubs and tests #121

Merged
merged 15 commits into from
Feb 9, 2024
Merged

feat: 1.6-compatibility stubs and tests #121

merged 15 commits into from
Feb 9, 2024

Conversation

ptiurin
Copy link
Collaborator

@ptiurin ptiurin commented Jan 29, 2024

Resolves #109

Description

Changes needed for dbt-core 1.6.

  • Setting can_clone to False, as FB does not have clone functionality
  • Stubbing materialized_view materialisation since that's also not supported
  • Test for dbt debug
  • Test for mat. view failing
  • Fixed bug in bool_or
  • Additional util tests

Checklist

  • I have run this code in development and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required/relevant for this PR.
  • I have run changie new and committed everything in .changes folder
  • I have removed any print or log calls that were added for debugging.
  • I have verified that this PR contains only code changes relevant to this PR.
  • If further integration tests are now passing I've edited tests/functional/adapter/* to account for this.
  • I have pulled/merged from the main branch if there are merge conflicts.
  • After pulling/merging main I have run pytest on the included or updated tests/functional/adapter/.

@ptiurin ptiurin changed the title 1.6-compatibility feat: 1.6-compatibility stubs and tests Jan 31, 2024
@ptiurin
Copy link
Collaborator Author

ptiurin commented Feb 6, 2024

@ptiurin ptiurin marked this pull request as ready for review February 6, 2024 11:56
@ptiurin ptiurin requested a review from a team as a code owner February 6, 2024 11:56
Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ptiurin ptiurin merged commit d1393f9 into main Feb 9, 2024
5 checks passed
@ptiurin ptiurin deleted the 1.6-compatibility branch February 9, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

upgrade to support dbt-core v1.6.0
2 participants