Added ability to include account value in profiles.yml to specify whi… #4
Conversation
…ch account to use.
… profiles.yml. Edited readme to reflect this change. Updated CHANGELOG.md.
dbt/adapters/firebolt/connections.py
Outdated
| lambda kv: "&" | ||
| + urllib.parse.quote(kv[0]) | ||
| + quote(kv[0]) | ||
| + "=" | ||
| + urllib.parse.quote(kv[1]), | ||
| + quote(kv[1]), | ||
| credentials.params.items(), |
There was a problem hiding this comment.
this thing looks like it also adds the query string, starting with &... maybe it could be combined with the url_vars section? maybe i'm being too picky? @miguel-firebolt, what's the use case for params anyway??
There was a problem hiding this comment.
This code is kind of messy. I'll fool around with it for a few minutes.
There was a problem hiding this comment.
Okay, it's done. Testing needs to be done using parameters, though, which I don't know how to do. @miguel-firebolt can you?
There was a problem hiding this comment.
I can't say I know what the use case for params is...
I can confirm this works. I tested using two accounts, using both engines on and one engine off at a time, in order to make sure it was always choosing the correct account. |
…ehension in construction of jdbc url.
|
Took @swanderz suggestion on adding parameters to jdbc url by using dictionary comprehension. |
|
I also tested and confirmed it works for me |
…ch account to use.