fix: Aggregating indices now allow multiple field names in the key column #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ome logic to error out with missing column names.
… only drop and rebuild if explicity told to using a variable on dbt run-operation stage_external_sources.
…d integration tests to pull_request.yml.
…ctory path issue in integration-tests.yml.
…ield to index_type for clarity.
…nal-table-edits should merge first.
…from main branch.
…eld-names-key-column
…thon-sdk version to 0.5.2.
…s, and added upper() to ensure match in errors in FireboltIndexConfig.
…s, I know that's not actually relevant to the job at hand.
…and for correctly naming the indexes if there is a list of keys.
|
@stepansergeevitch can you please review? |
…d integration tests to pull_request.yml.
…ctory path issue in integration-tests.yml.
…likely be merged at once.
…lt-db/dbt-firebolt into add-pytests-to-pr-actions
…ield to index_type for clarity.
…thon-sdk version to 0.5.2.
…s, and added upper() to ensure match in errors in FireboltIndexConfig.
…s, I know that's not actually relevant to the job at hand.
…and for correctly naming the indexes if there is a list of keys.
…d agg indexes, but parsing is done in an external library, so I ended up just making minor changes in the error messages.
…ince we're no longer going to make them a PR action.
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://packboard.atlassian.net/browse/FIR-8715
Checklist
CHANGELOG.mdand added information about my change.