test: Add connection v1 tests #104
Conversation
| }), | ||
| // Get account id | ||
| rest.get( | ||
| `https://${apiEndpoint}/iam/v2/accounts:getIdByName`, |
There was a problem hiding this comment.
shouldn't URL contain query parameter accountName=blblblbla ?
There was a problem hiding this comment.
It doesn't need to since otherwise it accepts all parameters. However, we sure can check that it was passed correctly. I've added an expect statement.
| } | ||
| ), | ||
| // Get default account | ||
| rest.get(`https://${apiEndpoint}/iam/v2/account`, (req, res, ctx) => { |
There was a problem hiding this comment.
at least in JDBC and .NET we use core/v1/account and core/v1/accounts for this is purpose. Is there a chance that I have to change the JDBC and .NET or these tests are wrong?
There was a problem hiding this comment.
Are you sure these drivers use core/v1 endpoints for the same operations? This is for getting default account (/iam/v2/account) or resolving account name to an id (iam/v2/accounts:getIdByName)
Firebolt 2.0 uses web/v3/account for these operations btw.
|
Some basic tests to improve coverage.