Avoid source link breakage with non-unescapable URLs

firebug · Jan 15, 2013 · 730c313 · 730c313
1 parent f76ce02
commit 730c313
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/extension/content/firebug/chrome/reps.js b/extension/content/firebug/chrome/reps.js
@@ -1928,16 +1928,17 @@ FirebugReps.SourceLink = domplate(Firebug.Rep,
 
         try
         {
-            var fileName = Url.getFileName(sourceLink.href);
+            // XXX This is wrong for at least data: URLs. E.g. evaluating
+            // "%2f" in the command line shows as "/".
+            var fileName = sourceLink.href;
+            fileName = Url.getFileName(fileName);
             fileName = decodeURIComponent(fileName);
         }
         catch(exc)
         {
             if (FBTrace.DBG_ERRORS)
                 FBTrace.sysout("reps.getSourceLinkTitle decodeURIComponent fails for \'" +
                     sourceLink.href + "\': " + exc, exc);
-
-            fileName = sourceLink.href;
         }
 
         var maxWidth = Firebug.sourceLinkLabelWidth;