Skip to content

Commit

Permalink
Issue 6183: Closure Inspector: some variables are treated as DOM prop…
Browse files Browse the repository at this point in the history
  • Loading branch information
simonlindholm committed Jan 13, 2013
1 parent dd3111e commit ea6b354
Showing 1 changed file with 3 additions and 41 deletions.
44 changes: 3 additions & 41 deletions extension/content/firebug/lib/dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -863,14 +863,15 @@ Dom.getDOMMembers = function(object)
{ return domMemberCache.Node; }
else if (object instanceof Event || object instanceof Dom.EventCopy)
{ return domMemberCache.Event; }
else if (object instanceof Object)
{ return domMemberCache.Object; }

return null;
};

Dom.isDOMMember = function(object, propName)
{
// We use "in" here instead of "hasOwnProperty" so that things on Object.prototype
// also get treated as DOM members.
// XXXsimon: Non-DOM objects should also get this behavior.
var members = Dom.getDOMMembers(object);
return members && propName in members;
};
Expand Down Expand Up @@ -1216,45 +1217,6 @@ domMemberMap.Window =
"getDefaultComputedStyle"
];

domMemberMap.Object =
[
"arguments",
"caller",
"length",
"name",
"__defineGetter__",
"__defineSetter__",
"__lookupGetter__",
"__lookupSetter__",
"apply",
"bind",
"call",
"constructor",
"create",
"defineProperties",
"defineProperty",
"freeze",
"getOwnPropertyDescriptor",
"getOwnPropertyNames",
"getPrototypeOf",
"hasOwnProperty",
"isExtensible",
"isFrozen",
"isGenerator",
"isPrototypeOf",
"isSealed",
"keys",
"preventExtensions",
"propertyIsEnumerable",
"seal",
"toLocaleString",
"toSource",
"toString",
"unwatch",
"valueOf",
"watch"
];

domMemberMap.Location =
[
"href",
Expand Down

0 comments on commit ea6b354

Please sign in to comment.