Skip to content

Commit

Permalink
Update package.json
Browse files Browse the repository at this point in the history
  • Loading branch information
@janodvarko
janodvarko committed Mar 30, 2012
1 parent e43f564 commit f634ee3
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions extension/package.json
View file
@@ -1,7 +1,7 @@
{
"name": "firebug",
"description": "Web Development Evolved - The Firebug you have known and loved",
"version": "1.9.0",
"name": "Firebug",
"description": "Web Development Evolved.",
"version": "1.10.0a6",

This comment has been minimized.

Sign in to view

Copy link
@joewalker

joewalker Apr 1, 2012

Member

I wonder if this shouldn't be:

"version": "1.10.0-a6",

NPM uses roughly the CommonJS package.json format which says that the version string should comply with semantic versioning which says (#10) that you should use a - to separate the 'patch version' from 'pre-release strings'.
The NPM description seems to be laxer but it can't help to add a - can it? The danger is that something like npm fails to parse you package.json in the future.

This comment has been minimized.

Sign in to view

Copy link
@cadorn

cadorn Apr 1, 2012

Member

Dashes don't work with mozilla tooling: https://developer.mozilla.org/en/Toolkit_version_format

You would need to reformat version upon publish.

I like semver but think it is insufficient. I think we will eventually arrive at a versioning format that is widely supported. We just need a few more JS package managers.

I am leaning towards the following: https://github.com/pinf/modules-js/blob/master/tests/semver.js
It allows me to select an unstable version and track it all the way up to major release and is compatible with mozilla.

This comment has been minimized.

Sign in to view

Copy link
@joewalker

joewalker Apr 2, 2012

Member

So you're arguing for:

"version": "1.10.0alpha6",

Right? (at least that's closest to their examples)
It seems a shame that the semver.js doesn't follow semver.org, but I agree following semver.js makes the most sense.

This comment has been minimized.

Sign in to view

Copy link
@cadorn

cadorn Apr 2, 2012

Member

Right. Or 1.10.0a6 or 1.10alpha6. I tried to stick with semver.org but over time had to add some rules. An important reasoning was to be able to have RC releases for betas.

e.g. 1.1alpha1rc1

I cannot remember if this works with mozilla tooling or if I had to convert the version before publish. I'll be revisiting this in more detail soon.
"homepage" : "http://getfirebug.com/",
"engines": {
"node": ">= 0.6.6"
Expand All @@ -10,7 +10,7 @@
"dryice": ">= 0.4.4",
"shelljs": ">= 0.0.2"
},
"author": "Jan Odvarko <odvarko@gmail.com>",
"author": "Joe Hewitt",
"repository" : {
"type" : "git",
"url" : "git://github.com/firebug/firebug.git"
Expand Down

0 comments on commit f634ee3

Please sign in to comment.