Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the option of copying URL/POST Parameters to the clipboard #19

Merged
merged 3 commits into from Jul 9, 2012
Merged

Added the option of copying URL/POST Parameters to the clipboard #19

merged 3 commits into from Jul 9, 2012

Conversation

bharaththiruveedula-zz
Copy link
Contributor

No description provided.

janodvarko added a commit that referenced this pull request Jul 9, 2012
@janodvarko
Merge pull request #19 from bharaththiruveedula/master
76d8f86 
Added the option of copying URL/POST Parameters to the clipboard
@janodvarko janodvarko merged commit 76d8f86 into firebug:master Jul 9, 2012
@janodvarko
Copy link
Member

Looks good Bharath, thanks!

Couple of notes:

  1. The try-catch is not necessary (I'll remove that). Also, if we use try-catch there should (almost) always be FBTrace log in the catch block so, we can see when the exception occurs
  2. The test doesn't have a driver so, it can be atomated

Honza

@janodvarko
Copy link
Member

Try catch removed at:
1568139

Bharath, the next step should be to finish the automated test case. Take a look at other Net panel tests, there are plenty of examples.

Honza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bharaththiruveedula-zz @janodvarko