Console dollar #37

Closed
wants to merge 13 commits into
from

Conversation

Projects
None yet
2 participants
@sroussey
Member

sroussey commented Sep 11, 2012

This covers issues 5764, 5779, 5786

@SebastianZ

This comment has been minimized.

Show comment
Hide comment
@SebastianZ

SebastianZ Aug 6, 2012

Member

Three points:

  • $() doesn't seem to work for me as expected (try $(".class1") on Joe's test case)
  • Better use constants instead of magic numbers.
  • Add a comment that the warning should be removed in a future version

Sebastian

Member

SebastianZ commented on 4bbd8f9 Aug 6, 2012

Three points:

  • $() doesn't seem to work for me as expected (try $(".class1") on Joe's test case)
  • Better use constants instead of magic numbers.
  • Add a comment that the warning should be removed in a future version

Sebastian

This comment has been minimized.

Show comment
Hide comment
@sroussey

sroussey Aug 6, 2012

Member
  • Wow, that is an old page of Joe's! It also loads prototype.js on the page, so Firebug will use that version of $, of course. I deal with more PrototypeJS stuff than jQuery stuff, believe it or not. So, yeah, this is a problem with the two JS libs defining incompatible versions, and our switching around. This is an example of the bogus bug reports you will get. ;)
  • Yeah, I will change if we decide to keep this functionality (or before)
  • Yes, one release later I think, we should pull the warning. I'll comment it up.
Member

sroussey replied Aug 6, 2012

  • Wow, that is an old page of Joe's! It also loads prototype.js on the page, so Firebug will use that version of $, of course. I deal with more PrototypeJS stuff than jQuery stuff, believe it or not. So, yeah, this is a problem with the two JS libs defining incompatible versions, and our switching around. This is an example of the bogus bug reports you will get. ;)
  • Yeah, I will change if we decide to keep this functionality (or before)
  • Yes, one release later I think, we should pull the warning. I'll comment it up.

This comment has been minimized.

Show comment
Hide comment
@SebastianZ

SebastianZ Aug 6, 2012

Member
  • Wow, that is an old page of Joe's!

Yes. Though I use it a lot for reproducing issues.

It also loads prototype.js on the page, so Firebug will use that version of $

Oh my! I totally forgot about that! Sorry, Steven! So I tested it on other sites and it's working as expected.

This is an example of the bogus bug reports you will get. ;)

Right. I wonder why we don't get this kind of reports more often already...

  • Yeah, I will change if we decide to keep this functionality (or before)
  • Yes, one release later I think, we should pull the warning. I'll comment it up.

Good.

Sebastian

Member

SebastianZ replied Aug 6, 2012

  • Wow, that is an old page of Joe's!

Yes. Though I use it a lot for reproducing issues.

It also loads prototype.js on the page, so Firebug will use that version of $

Oh my! I totally forgot about that! Sorry, Steven! So I tested it on other sites and it's working as expected.

This is an example of the bogus bug reports you will get. ;)

Right. I wonder why we don't get this kind of reports more often already...

  • Yeah, I will change if we decide to keep this functionality (or before)
  • Yes, one release later I think, we should pull the warning. I'll comment it up.

Good.

Sebastian

@SebastianZ

This comment has been minimized.

Show comment
Hide comment
@SebastianZ

SebastianZ Sep 12, 2012

Member

The changes for issue 5786 are unrelated. Why did you put them in there?

Sebastian

Member

SebastianZ commented Sep 12, 2012

The changes for issue 5786 are unrelated. Why did you put them in there?

Sebastian

@sroussey

This comment has been minimized.

Show comment
Hide comment
@sroussey

sroussey Sep 12, 2012

Member

Sorry, didn't have all the commits pushed to the repo

Member

sroussey commented Sep 12, 2012

Sorry, didn't have all the commits pushed to the repo

@sroussey sroussey closed this Sep 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment