Add --extra-host arguments to services
#1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a
docker:dindservice I realized that the--extra-hostarguments passed togitlab-ci-localget passed to the running image, but not to the services, which broke the resolution for my finagled$CI_REGISTRY_IMAGEin the docker in docker container (since the registry was resolved in the service container when usingdocker buildx build --push).Since the services already get the same volumes as the main container, I think it makes sense to pass the
extra-hostargs as well. What do you think? I don't know how controversial this change is, so if you think this is a bad idea, feel free to close the PR 馃槄 .P.S. Is the test fine like this? I mostly cobbled it together by combining the existing
add-host <test-job>test with theservices <multie-job>test.