Fix CI_REGISTRY_IMAGE (again)
#1087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exact handling on the GitLab side can be found at <https://gitlab.com/gitlab-org/gitlab/-/blob/0c47378a58c35c234c4eae0d9274763db1cdc7f1/app/models/project.rb#L1291-1295>.
According to <https://gitlab.com/gitlab-org/gitlab/-/blob/master/doc/ci/variables/predefined_variables.md#L109> the `PROJECT_PATH_SLUG` is lowercased.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, while running the master branch locally, I realized that my change in #1085 actually broke
CI_REGISTRY_IMAGE. The reason is that the full string gets lowercased (i.e. something like$ci_registry/some/lowercased/path), which means$CI_REGISTRYdoes not get resolved (because the variable name was lowercased) 馃槄 . Thats what I get for not testing properly 馃う .I have added some tests now to make sure the behaviour is correct now (incidentally, I checked the gitlab source code and it seems they only lowercase the path, not the host, so this code matches the upstream behaviour more closely).
While writing the test I realized that
CI_PROJECT_PATH_SLUGalso needs to be lowercased to match the upstream behaviour.Sorry for the trouble 馃槗